Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade deck to v1.10.0, update the affected deck calls in sendconfig #2125

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

mflendrich
Copy link
Contributor

This PR:

@rainest please kindly double-check that the use of selectTags when reading the target state is as intended after #517.

includes updates to the breaking deck API changes introduced in Kong/deck#517 and Kong/deck#436
@mflendrich mflendrich requested a review from a team as a code owner January 3, 2022 23:16
@mflendrich mflendrich temporarily deployed to Configure ci January 3, 2022 23:16 Inactive
@github-actions
Copy link

github-actions bot commented Jan 3, 2022

Licenses differ between commit f35eada and base:

+++ pr_licenses.csv	2022-01-03 23:17:52.659642296 +0000
@@ -58,6 +58,7 @@
 github.com/sirupsen/logrus,https:/sirupsen/logrus/blob/master/LICENSE,MIT
 github.com/spf13/cobra,https:/spf13/cobra/blob/master/LICENSE.txt,Apache-2.0
 github.com/spf13/pflag,https:/spf13/pflag/blob/master/LICENSE,BSD-3-Clause
+github.com/ssgelm/cookiejarparser,https:/ssgelm/cookiejarparser/blob/master/LICENSE.md,MIT
 github.com/tidwall/gjson,https:/tidwall/gjson/blob/master/LICENSE,MIT
 github.com/tidwall/match,https:/tidwall/match/blob/master/LICENSE,MIT
 github.com/tidwall/pretty,https:/tidwall/pretty/blob/master/LICENSE,MIT```

@mflendrich mflendrich temporarily deployed to Configure ci January 3, 2022 23:30 Inactive
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were already getting tags via other means, which is equivalent to including tags inside the target content file. That was already supported in deck; the 1.8 change just adds additional handling for the CLI argument also; including it in the file.Get() call just confirms that the file and argument tags don't differ.

That won't ever occur here (we use the controller tag arg for both), so we're good to go. Were there any issue introduced by the change, integration tests would fall over because the controller wouldn't be able to see its own resources.

@rainest rainest merged commit a0f6eb4 into main Jan 4, 2022
@rainest rainest deleted the deps/deck-v1.10.0 branch January 4, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Deck to v1.8.x or newer
2 participants