Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: more L7 gateway API conformance tests #2345

Merged
merged 2 commits into from
Mar 22, 2022
Merged

tests: more L7 gateway API conformance tests #2345

merged 2 commits into from
Mar 22, 2022

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Mar 22, 2022 •
edited
Loading

What this PR does / why we need it:

This adds most of the rest of the L7 Gateway conformance tests, minus cross namespace ones that will be taken care of later as a part of #2080.

Which issue this PR fixes

Resolves #2210

PR Readiness Checklist:

  • the CHANGELOG.md release notes have been updated

@shaneutt shaneutt self-assigned this Mar 22, 2022
@shaneutt shaneutt changed the title shaneutt/more l7 gw conformance tests: more L7 gateway API conformance tests Mar 22, 2022
@shaneutt shaneutt force-pushed the shaneutt/more-l7-gw-conformance branch from 9c7e267 to a47d0e1 Compare March 22, 2022 16:25
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 16:28 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 16:28 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 16:29 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 16:30 Inactive
@shaneutt shaneutt force-pushed the shaneutt/more-l7-gw-conformance branch from a47d0e1 to 66bd4f0 Compare March 22, 2022 16:41
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 16:52 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 16:52 Inactive
@shaneutt shaneutt temporarily deployed to Configure ci March 22, 2022 17:08 Inactive
@shaneutt shaneutt marked this pull request as ready for review March 22, 2022 17:13
@shaneutt shaneutt requested a review from a team as a code owner March 22, 2022 17:13
rainest
rainest approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor opportunity to change the name format to match Ingress' precedent. I'm pretty ambivalent about it, feel free to go ahead with either.

internal/dataplane/parser/translate_httproute.go Show resolved Hide resolved
internal/dataplane/parser/translate_httproute.go Show resolved Hide resolved
internal/dataplane/parser/translate_httproute_test.go Show resolved Hide resolved
internal/dataplane/parser/translate_httproute_test.go Show resolved Hide resolved
internal/dataplane/parser/translate_httproute_test.go Show resolved Hide resolved
internal/dataplane/parser/translate_httproute_test.go Show resolved Hide resolved
@shaneutt shaneutt merged commit c621221 into main Mar 22, 2022
@shaneutt shaneutt deleted the shaneutt/more-l7-gw-conformance branch March 22, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest approved these changes

Assignees

@shaneutt shaneutt

Labels
area/ci area/tests ci/license/unchanged priority/medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

L7 Gateway API Conformance
2 participants
@shaneutt @rainest