docs: add IngressClassParams KEP #2536
Conversation
There was a problem hiding this comment.
Mostly LGTM, my main comment is about the graduation criteria please see the comments below.
Also are we aware of any end-users that have asked for this feature? As far as I can tell this has been driven entirely by maintainers historically. That doesn't mean it shouldn't exist, but I do think it's worth talking about, and maybe reflecting in the KEPs motivations.
Well my understanding was that there was #1586 which was proposed by our user but the issue (#1131) was brought up by one of maintainers. |
Good call, I was missing this piece of the puzzle. @larribas are you still interested in this feature, and would you have some time to weigh in here? |
Co-authored-by: Shane Utt <[email protected]>
Co-authored-by: Shane Utt <[email protected]>
Co-authored-by: Shane Utt <[email protected]>
Co-authored-by: Shane Utt <[email protected]>
Bumps [github.com/spf13/cobra](https:/spf13/cobra) from 1.4.0 to 1.5.0. - [Release notes](https:/spf13/cobra/releases) - [Commits](spf13/cobra@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
If the IngressClass controller is disabled, also disable the additional IngressClass watches in other controllers.
Increase the default proxy timeout to 30s. Add a log indicating the increase timeout flag when the controller exceeds the proxy timeout.
Bumps [google.golang.org/api](https:/googleapis/google-api-go-client) from 0.84.0 to 0.85.0. - [Release notes](https:/googleapis/google-api-go-client/releases) - [Changelog](https:/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.84.0...v0.85.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Mattia Lavacca <[email protected]>
#2603) Bumps [sigs.k8s.io/controller-runtime](https:/kubernetes-sigs/controller-runtime) from 0.12.0 to 0.12.2. - [Release notes](https:/kubernetes-sigs/controller-runtime/releases) - [Changelog](https:/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.12.0...v0.12.2) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Rework managed Listener handling. The Gateway controller no longer replaces user-provided Listeners with a set of Listeners derived from the Kong proxy Service and listen configuration. It only checks to ensure a Kong listen with the correct protocol is available for the requested Listener. If there is none, it marks the Listener detached because its protocol is unsupported, or because no protocol is configured for the specific port. Remove allowedRoutes merger. This is unnecessary with user-defined Listeners preserved. Remove utility functions used to compare Kong-derived and Gateway-derived Listener sets. Comparisons against Kong configuration now contribute to Listener compatibility checks on a per-Listen basis. Remove any awareness of Listener history when calculating status other than the attachedRoutes figure from Status. If any two Listeners result in a conflict condition, mark all Listeners with that port or hostname conflicted. Adding a new Listener in conflict with an existing Listener will break the existing Listener and detach it. Exclude ClusterIP addresses from Gateway address status. Only LoadBalancer addresses, if present, will be advertised.
) Bumps [github.com/stretchr/testify](https:/stretchr/testify) from 1.7.4 to 1.7.5. - [Release notes](https:/stretchr/testify/releases) - [Commits](stretchr/testify@v1.7.4...v1.7.5) --- updated-dependencies: - dependency-name: github.com/stretchr/testify dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
What this PR does / why we need it:
It defines a KEP for #1131
Which issue this PR fixes:
addresses #1131
Special notes for your reviewer:
Related PR with proposal of implementation can be found in #2535