Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests) pin Gateway CRD version #2551

Merged
merged 1 commit into from
Jun 7, 2022
Merged

chore(tests) pin Gateway CRD version #2551

merged 1 commit into from
Jun 7, 2022

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jun 7, 2022

What this PR does / why we need it:
Pin the Gateway APIs CRD version, currently to 0.4.2

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Addresses CI failures like

2022-06-07T13:56:57.0069650Z     tcproute_test.go:661: 
2022-06-07T13:56:57.0072564Z         	Error Trace:	tcproute_test.go:661
2022-06-07T13:56:57.0072985Z         	Error:      	Received unexpected error:
2022-06-07T13:56:57.0074015Z         	            	the server could not find the requested resource (post referencepolicies.gateway.networking.k8s.io)
2022-06-07T13:56:57.0074575Z         	Test:       	TestTCPRouteReferencePolicy

Special notes for your reviewer:

Upstream master changed this in kubernetes-sigs/gateway-api#1188 and the unversioned CRD URL uses master. This presents a bit of a conundrum for if we want to test unreleased stuff, but I think I'm okay living with that and just not merging anything for unreleased Gateway API versions. If we want to do that we probably want to write a draft and run tests locally or change back to master temporarily in the draft.

@rainest rainest requested a review from a team as a code owner June 7, 2022 19:12
@rainest rainest temporarily deployed to Configure ci June 7, 2022 19:13 Inactive
@rainest rainest temporarily deployed to Configure ci June 7, 2022 19:13 Inactive
@rainest rainest temporarily deployed to Configure ci June 7, 2022 19:14 Inactive
@rainest rainest enabled auto-merge (rebase) June 7, 2022 19:17
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I get that the breaking change upstream was disruptive, it also was something that we found out automatically by way of doing our normal everyday work. If we make this change, we then have to remind ourselves to update this in time, at least up until the point where upstream is considered stable.

I would ask that we add a follow up issue for this before we consider this resolved so that we can eventually use whatever the latest stable is.

@rainest rainest temporarily deployed to Configure ci June 7, 2022 19:49 Inactive
@rainest rainest temporarily deployed to Configure ci June 7, 2022 19:49 Inactive
@rainest rainest merged commit 1ee809b into main Jun 7, 2022
@rainest rainest temporarily deployed to Configure ci June 7, 2022 20:13 Inactive
@rainest rainest deleted the rainest-patch-1 branch June 7, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants