fix: treat status conditions of gateway and gatewayclass as snapshots #2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randmonkey
force-pushed
the
fix/gateway_conditions_as_snapshots
branch
from
4be6fb7
to
940fe68
Compare
randmonkey
force-pushed
the
fix/gateway_conditions_as_snapshots
branch
from
940fe68
to
b878640
Compare
rainest
approved these changes
Aug 9, 2022
rainest
pushed a commit
that referenced
this pull request
Jul 6, 2023
rainest
pushed a commit
that referenced
this pull request
Jul 10, 2023
rainest
pushed a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
treat status conditions of
gatewayandgatewayclassas snapshots, replace the condition with same type when update conditions.Which issue this PR fixes:
fixes #2694
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR