Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestIngressClassRegexToggle failures prevent the PRs from being merged #2942

Closed
1 task done
jrsmroz opened this issue Sep 16, 2022 · 1 comment · Fixed by #2943
Closed
1 task done

TestIngressClassRegexToggle failures prevent the PRs from being merged #2942

jrsmroz opened this issue Sep 16, 2022 · 1 comment · Fixed by #2943
Labels
area/ci area/tests bug Something isn't working

Comments

@jrsmroz
Copy link
Contributor

jrsmroz commented Sep 16, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I try to merge the PR, the TestIngressClassRegexToggle from integration-tests-feature-gates suite fails constantly, preventing the merges.

In the PR, the integration-tests-feature-gates has been rerun at least 5 times, each time failing. https:/Kong/kubernetes-ingress-controller/actions/runs/3061338924/jobs/4953156367

Expected Behavior

TestIngressClassRegexToggle should not fail that often.

Steps To Reproduce

1. Create the PR
2. Wait for the tests to complete.

Kong Ingress Controller version

No response

Kubernetes version

No response

Anything else?

No response
@jrsmroz jrsmroz added bug Something isn't working area/ci area/tests labels Sep 16, 2022
@jrsmroz jrsmroz mentioned this issue Sep 16, 2022
Merged
@jrsmroz
Copy link
Contributor Author

jrsmroz commented Sep 16, 2022

I can reproduce it locally by running:

KONG_CONTROLLER_FEATURE_GATES="GatewayAlpha=true,CombinedRoutes=true" go test -v -timeout 180s -tags integration_tests -run TestIngressClassRegexToggle

However, removing the CombinedRoutes, makes the test pass.

KONG_CONTROLLER_FEATURE_GATES="GatewayAlpha=true" go test -v -timeout 180s -tags integration_tests -run TestIngressClassRegexToggle

@jrsmroz jrsmroz mentioned this issue Sep 17, 2022
Merged
1 task
@jrsmroz jrsmroz changed the title TestIngressClassRegexToggle failures prevent the PRs to be merged TestIngressClassRegexToggle failures prevent the PRs from being merged Sep 17, 2022
@jrsmroz jrsmroz mentioned this issue Sep 21, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci area/tests bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@jrsmroz