-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check nils in ingressClass.Parameters #2970
Conversation
11adb9b
to
1719ba6
Compare
Initial failures in integration-tests-dbless were for UDPRoute and TLSRoute: UDPRoute failed because the listener had no valid Kong port to associate with. Somehow this port was present on the deployment, but was TCP instead of UDP. Not sure how KTF would have that temporarily, but the code there does look at least partially incorrect. UDP stream listens should live in a different config section because of LoadBalancer inability to handle mixed TCP/UDP services:
However, elsewhere it tries to set the
TLSRoute unsure. Its listener is fine, but the route itself has no status and was apparently never acknowledged. Controller logs appear to simply not see it. |
}, | ||
} | ||
cacheStores, err := store.NewCacheStoresFromObjs() | ||
assert.NoError(t, err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those would better use require
instead to prevent continuing execution, so that when an error occurs we don't continue the test as it would be pointless.
What this PR does / why we need it:
fix panics when some field is
nil
iningressClass.spec.parameters
Which issue this PR fixes:
fixes #2958.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR