Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3097): create warning translation failure events for CA secrets #3125

Merged
merged 13 commits into from
Nov 3, 2022

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Nov 3, 2022

What this PR does / why we need it:

It starts creating Kubernetes Events for all TranslationFailures detected during the translation phase. It will create one event per causing object. An integration test suite is also added in order to track all translation failure cases - that should make eventual future refactors safer (e.g. moving validation rules from the parser to the controllers).

Which issue this PR fixes:

Part of #3097.

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 07:49 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 08:13 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 08:13 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 09:01 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 09:29 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 09:29 Inactive
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 3, 2022
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 11:29 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 11:38 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 11:42 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 11:50 Inactive
@czeslavo czeslavo changed the title feat(#3097): create warning translation failure events feat(#3097): create warning translation failure events for CA secrets Nov 3, 2022
@czeslavo czeslavo marked this pull request as ready for review November 3, 2022 11:52
@czeslavo czeslavo requested a review from a team as a code owner November 3, 2022 11:52
@czeslavo czeslavo self-assigned this Nov 3, 2022
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 11:57 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 12:18 Inactive
@czeslavo czeslavo requested a review from pmalek November 3, 2022 12:18
@czeslavo czeslavo enabled auto-merge (squash) November 3, 2022 12:41
pmalek
pmalek previously approved these changes Nov 3, 2022
@czeslavo czeslavo force-pushed the feat/create-warning-translation-events branch from 11bdd43 to c5c1b55 Compare November 3, 2022 13:37
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 13:37 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 14:00 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 3, 2022 14:00 Inactive
@czeslavo
Copy link
Contributor Author

czeslavo commented Nov 3, 2022

@pmalek PTAL, I had to force push to trigger checks as they got stuck.

@czeslavo czeslavo requested a review from pmalek November 3, 2022 14:05
@czeslavo czeslavo merged commit bf5fb88 into main Nov 3, 2022
@czeslavo czeslavo deleted the feat/create-warning-translation-events branch November 3, 2022 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants