Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#3097): propagate translation failures for http routes not having backend refs #3167

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Nov 14, 2022

What this PR does / why we need it:

Adds propagation of translation failures for HTTPRoute not having any backendRef specified.

Which issue this PR fixes:

Part of #3097.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@czeslavo czeslavo added the area/feature New feature or request label Nov 14, 2022
@czeslavo czeslavo self-assigned this Nov 14, 2022
@czeslavo czeslavo temporarily deployed to Configure ci November 14, 2022 10:35 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 14, 2022 10:36 Inactive
@czeslavo czeslavo marked this pull request as ready for review November 14, 2022 10:36
@czeslavo czeslavo requested a review from a team as a code owner November 14, 2022 10:36
@czeslavo czeslavo temporarily deployed to Configure ci November 14, 2022 11:01 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 14, 2022 11:01 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 15, 2022 14:42 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 15, 2022 15:06 Inactive
@czeslavo czeslavo temporarily deployed to Configure ci November 15, 2022 15:06 Inactive
@czeslavo czeslavo enabled auto-merge (squash) November 16, 2022 10:17
@czeslavo czeslavo merged commit df1f9d9 into main Nov 16, 2022
@czeslavo czeslavo deleted the feat/http-route-cant-be-routed-propagation branch November 16, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants