Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: fix GatewayInvalidRouteKind gateway API conformance test #3513

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Feb 8, 2023

What this PR does / why we need it:

The conformance test GatewayInvalidRouteKind is enabled again

Which issue this PR fixes:

Fixes #3228
Part of #3305

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

- [ ] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@mlavacca mlavacca requested a review from a team as a code owner February 8, 2023 11:53
@mlavacca mlavacca marked this pull request as draft February 8, 2023 11:55
@mlavacca mlavacca force-pushed the conformance-GatewayInvalidRouteKind branch 2 times, most recently from d2f77fb to a512dcb Compare February 8, 2023 16:11
@mlavacca mlavacca changed the title feat: fix GatewayInvalidRouteKind conformance test conformance: fix GatewayInvalidRouteKind gateway API conformance test Feb 8, 2023
@mlavacca mlavacca force-pushed the conformance-GatewayInvalidRouteKind branch from 8ae2278 to 353dbbc Compare February 8, 2023 18:22
@mlavacca mlavacca marked this pull request as ready for review February 8, 2023 18:22
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 72.2% // Head: 72.1% // Decreases project coverage by -0.1% ⚠️

Coverage data is based on head (ac2e84e) compared to base (f196d26).
Patch coverage: 87.3% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3513     +/-   ##
=======================================
- Coverage   72.2%   72.1%   -0.1%     
=======================================
  Files        126     126             
  Lines      14546   14554      +8     
=======================================
- Hits       10507   10503      -4     
- Misses      3376    3386     +10     
- Partials     663     665      +2     
Impacted Files Coverage Δ
internal/controllers/gateway/gateway_utils.go 89.9% <87.3%> (-0.1%) ⬇️
...nternal/controllers/gateway/tlsroute_controller.go 73.4% <0.0%> (-2.4%) ⬇️
...ternal/controllers/gateway/httproute_controller.go 69.7% <0.0%> (-1.9%) ⬇️
internal/dataplane/kongstate/service.go 66.0% <0.0%> (-1.3%) ⬇️
...nternal/controllers/gateway/tcproute_controller.go 72.0% <0.0%> (+2.0%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

internal/controllers/gateway/gateway_utils.go Show resolved Hide resolved
internal/controllers/gateway/gateway_utils.go Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_utils.go Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_utils.go Outdated Show resolved Hide resolved
@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Feb 13, 2023
@mlavacca mlavacca force-pushed the conformance-GatewayInvalidRouteKind branch from 353dbbc to 1214f9f Compare February 15, 2023 15:10
@mlavacca mlavacca merged commit 2ab8b94 into main Feb 16, 2023
@mlavacca mlavacca deleted the conformance-GatewayInvalidRouteKind branch February 16, 2023 13:17
@pmalek pmalek added the fix label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API fix size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ListenerStatus.SupportedKinds compliant with GW API specification
3 participants