feat: add dataplane metrics label #3521
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds
dataplane
metrics label to account for KIC sending configuration to more than 1 gateway.The outcome of this PR will be that users will see separate time series for each dataplane for the following metrics:
ingress_controller_configuration_push_count
ingress_controller_configuration_push_duration_milliseconds
Which issue this PR fixes:
Fixes #3417
Special notes for your reviewer:
Blocked by #3421
This will make it so all
ingress_controller_configuration_push_count
andingress_controller_configuration_push_duration_milliseconds
time series will change. Regardless of running SCD or not. If we'd like to retain the current behaviour (not include the label) then we'd need to tweak this PR to account for this, i.e.:dataplane
label when running with 1 Gateway, communicating throughlocalhost
/127.0.0.1
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR