-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: translate HTTPRoute to expression based routes #3956
Conversation
f360323
to
2e75729
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3956 +/- ##
=======================================
- Coverage 58.8% 58.0% -0.8%
=======================================
Files 139 142 +3
Lines 16115 16379 +264
=======================================
+ Hits 9477 9508 +31
- Misses 5991 6263 +272
+ Partials 647 608 -39
☔ View full report in Codecov by Sentry. |
6f99046
to
98758a6
Compare
98758a6
to
b39f9b2
Compare
b39f9b2
to
0e1d215
Compare
0e1d215
to
e23b288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me 👍 Just a couple of nits from my side.
1f6f91c
to
32b0429
Compare
What this PR does / why we need it:
translate HTTPRoute to expression based Kong routes.
Which issue this PR fixes:
fixes #3751.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR