Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: translate HTTPRoute to expression based routes #3956

Merged
merged 3 commits into from
May 10, 2023

Conversation

randmonkey
Copy link
Contributor

@randmonkey randmonkey commented May 5, 2023

What this PR does / why we need it:

translate HTTPRoute to expression based Kong routes.

Which issue this PR fixes:

fixes #3751.

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@randmonkey randmonkey requested a review from a team as a code owner May 5, 2023 08:27
@randmonkey randmonkey self-assigned this May 5, 2023
@randmonkey randmonkey added this to the KIC v2.10.0 milestone May 5, 2023
@randmonkey randmonkey marked this pull request as draft May 5, 2023 08:28
@randmonkey randmonkey added area/feature New feature or request work in progress Work In Progress labels May 5, 2023
@randmonkey randmonkey force-pushed the feat/translate_httproute_expression branch from f360323 to 2e75729 Compare May 5, 2023 08:43
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 83.3% and project coverage change: -0.8 ⚠️

Comparison is base (0762e8d) 58.8% compared to head (1f6f91c) 58.0%.

❗ Current head 1f6f91c differs from pull request most recent head 32b0429. Consider uploading reports for the commit 32b0429 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3956     +/-   ##
=======================================
- Coverage   58.8%   58.0%   -0.8%     
=======================================
  Files        139     142      +3     
  Lines      16115   16379    +264     
=======================================
+ Hits        9477    9508     +31     
- Misses      5991    6263    +272     
+ Partials     647     608     -39     
Impacted Files Coverage Δ
internal/dataplane/parser/translate_grpcroute.go 4.7% <0.0%> (ø)
internal/dataplane/parser/translate_tcproute.go 10.9% <0.0%> (ø)
internal/dataplane/parser/translate_tlsroute.go 6.6% <0.0%> (ø)
internal/dataplane/parser/translate_udproute.go 10.9% <0.0%> (ø)
internal/dataplane/parser/translate_httproute.go 77.0% <37.5%> (-4.6%) ⬇️
internal/util/builder/httproutefilter.go 54.3% <54.3%> (ø)
internal/dataplane/parser/translators/httproute.go 92.7% <88.0%> (-2.2%) ⬇️
...rnal/dataplane/parser/translators/httproute_atc.go 98.7% <98.7%> (ø)
...ternal/dataplane/parser/translators/ingress_atc.go 88.3% <100.0%> (ø)
internal/util/builder/httproutematch.go 100.0% <100.0%> (ø)

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@randmonkey randmonkey force-pushed the feat/translate_httproute_expression branch 2 times, most recently from 6f99046 to 98758a6 Compare May 6, 2023 09:14
@pull-request-size pull-request-size bot added size/XL and removed size/L labels May 6, 2023
@randmonkey randmonkey force-pushed the feat/translate_httproute_expression branch from 98758a6 to b39f9b2 Compare May 8, 2023 07:31
@randmonkey randmonkey changed the title [WIP] feat: translate HTTPRoute to expression based routes feat: translate HTTPRoute to expression based routes May 8, 2023
@randmonkey randmonkey marked this pull request as ready for review May 8, 2023 07:32
@randmonkey randmonkey force-pushed the feat/translate_httproute_expression branch from b39f9b2 to 0e1d215 Compare May 8, 2023 08:52
@randmonkey randmonkey force-pushed the feat/translate_httproute_expression branch from 0e1d215 to e23b288 Compare May 9, 2023 04:16
@randmonkey randmonkey removed the work in progress Work In Progress label May 9, 2023
Copy link
Contributor

@czeslavo czeslavo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍 Just a couple of nits from my side.

internal/dataplane/parser/translate_errors.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translate_httproute.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translate_httproute.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translators/httproute_atc.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translators/httproute_atc.go Outdated Show resolved Hide resolved
@randmonkey randmonkey force-pushed the feat/translate_httproute_expression branch from 1f6f91c to 32b0429 Compare May 10, 2023 09:56
@randmonkey randmonkey requested a review from czeslavo May 10, 2023 09:56
@randmonkey randmonkey enabled auto-merge (squash) May 10, 2023 10:28
@randmonkey randmonkey merged commit ba8475d into main May 10, 2023
@randmonkey randmonkey deleted the feat/translate_httproute_expression branch May 10, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translate HTTPRoute into expression based routes
2 participants