Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make upgrade tests more robust #4117

Merged
merged 6 commits into from
Jun 1, 2023
Merged

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented May 31, 2023

What this PR does / why we need it:

It introduces two main changes to the upgrade tests that should make them more reliable:

  1. Ensure that after the controller deployment is upgraded, we actually wait until all new replicas are rolled out and become ready so that we're sure that we're testing against the new version.
  2. Add a new path to the Ingress after the upgrade is done and test against it to make sure that the new configuration is processed correctly (without that we were only verifying that the old Kong Gateway instance was configured, but it could be the configuration pushed by the old controller).

https:/Kong/kubernetes-ingress-controller/actions/runs/5142252037/jobs/9255887769 test failure proves that if we set the feature gate FillIDs=true, the upgrade will fail. To fix that we will bump deck version to v1.21.0 which will make the test pass.

Which issue this PR fixes:

Noticed when working on #4025.

@czeslavo czeslavo changed the base branch from main to all-in-one-migrations May 31, 2023 16:35
@czeslavo czeslavo added the ci/run-e2e Trigger e2e test run from PR label May 31, 2023
@czeslavo czeslavo added this to the KIC v2.10.0 milestone May 31, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests were started at https:/Kong/kubernetes-ingress-controller/actions/runs/5135464942

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label May 31, 2023
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud May 31, 2023 17:05 — with GitHub Actions Inactive
Base automatically changed from all-in-one-migrations to main May 31, 2023 17:39
@czeslavo czeslavo self-assigned this May 31, 2023
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@team-k8s-bot team-k8s-bot temporarily deployed to gcloud June 1, 2023 08:51 — with GitHub Actions Inactive
@czeslavo czeslavo marked this pull request as ready for review June 1, 2023 09:04
@czeslavo czeslavo requested a review from a team as a code owner June 1, 2023 09:04
@czeslavo czeslavo enabled auto-merge (squash) June 1, 2023 10:12
pmalek
pmalek previously approved these changes Jun 1, 2023
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits for consideration

test/e2e/utils_test.go Outdated Show resolved Hide resolved
test/e2e/helpers_test.go Outdated Show resolved Hide resolved
@czeslavo czeslavo merged commit f9f69d1 into main Jun 1, 2023
@czeslavo czeslavo deleted the upgrade-tests-improvements branch June 1, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants