chore(deps) update to GWAPI 0.7.1 #4142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4142 +/- ##
=====================================
Coverage 60.6% 60.6%
=====================================
Files 150 150
Lines 16843 16822 -21
=====================================
- Hits 10213 10201 -12
+ Misses 5984 5976 -8
+ Partials 646 645 -1
☔ View full report in Codecov by Sentry. |
2 tasks
rainest
force-pushed
the
chore/gwapi-upgrade
branch
11 times, most recently
from
e1da095
to
a125cfd
Compare
pmalek
reviewed
Jun 13, 2023
rainest
force-pushed
the
chore/gwapi-upgrade
branch
from
1125944
to
8b710c1
Compare
pmalek
reviewed
Jun 13, 2023
rainest
force-pushed
the
chore/gwapi-upgrade
branch
from
8b710c1
to
43104eb
Compare
Use the Programmed reason instead of Ready for valid Listeners. Apply the Accepted condition to Listeners when it is true, instead of only when it is false. This is an additional conformance requirement. GWAPI 0.7 kinda deprecated Ready per: https:/kubernetes-sigs/gateway-api/blob/v0.7.1/apis/v1beta1/gateway_types.go#L880-L897 Although Programmed does not replace Ready and was already present, we should not use Ready until its status is decided. As Programmed precedes ready (Programmed indicates that a Listener is available in configuration, whereas Ready means that the configuration is definitely live--difficult to determine in an eventually consistent environment), it is suitable for checks where we previously used Ready.
Following kubernetes-sigs/gateway-api#1877 the Ready condition is effectively deprecated. Programmed is appropriate for cases where we used Ready as it represents a state where Readiness is expected based on submitted configuration.
Skip a conformance test that fails because it requires a non-standard port not exposed by our test Gateway. Skip an unclear rule precedence test. Although the requirement is unclear, it is unlikely that the controller can address this, as precedence is governed by Kong. Skip the HTTP mirroring conformance test. This extended feature is not supported.
Co-authored-by: Patryk Małek <[email protected]>
rainest
force-pushed
the
chore/gwapi-upgrade
branch
from
43104eb
to
71a1e09
Compare
|
More rebases since something happened in main that Github thought was a conflict, but wasn't? Dunno, fetch and rebase to origin/main didn't actually raise any conflicts in |
pmalek
reviewed
Jun 13, 2023
pmalek
added
area/gateway-api
pmalek
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
GWAPI upgrades and a conformance fix.
Which issue this PR fixes:
Fix #3726
Fix #2953
Fix #3990
Special notes for your reviewer:
kubernetes-sigs/gateway-api#1888 and kubernetes-sigs/gateway-api#1832 (comment) change expectations around statuses. This PR includes changes that adhere to the 0.7.1 conformance test informed by these changes, but it's possible we missed something not covered in conformance. GWAPI doesn't really provide an expected state flowchart for statuses (we have to go off individual condition descriptions in the API docs), which makes it a bit difficult to determine if our state changes are truly correct absent conformance tests.
Changes to conformance suite covered in:
#4166
#4165
#4164
Also skips mesh stuff but no issue for that as I assume we have no intention to implement that for Kong-based products.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR