fix: fix incorrect .Is() method on update skipped due to backoff error #4213
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes an issue where KIC crash due to a stack overflow when a broken config is applied in dbmode.
The problematic piece was:
which didn't work as intended.
.Is()
is meant to compare errors, as in compare their values, not types.Where this was called we intended to check the type of an error, not it's value.
The stack overflow is prevent by removing the
.Is()
method fromUpdateSkippedDueToBackoffStrategyError
as it's not needed now.The test that failed due to a stack overflow before this change was introduced and passes now:
Which issue this PR fixes:
Fixes: #4212
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR