chore(ci): do not run e2e tests triggered by label on GKE clusters #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests with KIND-based clusters were started at https:/Kong/kubernetes-ingress-controller/actions/runs/5387421798 |
czeslavo
approved these changes
Jun 27, 2023
pmalek
approved these changes
Jun 27, 2023
czeslavo
pushed a commit
that referenced
this pull request
Jul 6, 2023
czeslavo
added a commit
that referenced
this pull request
Jul 6, 2023
…4235) (#4287) Co-authored-by: Jakub Warczarek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently label
ci/run-e2eruns GKE-based tests with anightlyimage (instead of one from PR). It is pointless because you want to test the PR code. Change in this PR ensures that only KIND-based clusters are used for tests and proper commentis added. For implementing it for GKE clusters (building image from PR and loading it to a cluster) separate issue exists Kong/kubernetes-testing-framework#587.