-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crd): add KongConsumerGroup CRD #4325
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4325 +/- ##
=======================================
- Coverage 65.5% 65.3% -0.2%
=======================================
Files 154 154
Lines 17740 17866 +126
=======================================
+ Hits 11632 11680 +48
- Misses 5378 5456 +78
Partials 730 730
☔ View full report in Codecov by Sentry. |
6b2a54f
to
28a9762
Compare
28a9762
to
a544963
Compare
4530afb
to
a68adba
Compare
a68adba
to
e5d1766
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to add the store code in here as well? Those functions are essentially boilerplate AFAIK (they probably could also be templated even, we just never bothered). I'd prefer to have the intermediate PR be "does effectively nothing, successfully" versus "does nothing, expected to produce benign errors".
Stuffing both the scaffolding and actual functional code into the same PR as separate commits would also be fine. The Github UX for per-commit diffs within a PR isn't perfect, but it is available. I at least can glaze over the parts I know are boilerplate since it's familiar boilerplate. Dunno what overall preference would be--it'd be a good retro item.
e6ce590
to
ce5a14a
Compare
ce5a14a
to
ac6c300
Compare
From my perspective, it doesn't matter much @rainest. I can do whatever is preferred. Somewhere the division has to be made to keep a reasonable size of PRs. I consider generating messages in case of try of usage as a thing that clearly indicates the WIP state of this. We do not have an approach for testing put into the cache. The next PR will include both cache and parser with more e2e-like tests |
ac6c300
to
8597156
Compare
What this PR does / why we need it:
The scope of this PR is to introduce a new CRD
KongConsumerGroup
and boilerplate controller for it that does nothing.Which issue this PR fixes:
This is a part of #3728 - introducing support for Consumer Groups in KIC.
Special notes for your reviewer:
Touched files:
pkg/apis/configuration/v1beta1/kongconsumergroup_types.go
hack/generators/controllers/networking/main.go
internal/manager/controllerdef.go
config/crd/kustomization.yaml
PROJECT
CHANGELOG.md
test/envtest/crds_envtest_test.go
the rest was modified by code generators run with
make manifest && make generate
applying example configuration
is successful in logs
can be observed, because cache for this new Kind is implemented in a separate PR to make it easier for reviewer.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR