fix: Set StripPath to false in routes translated from HTTPRoute when ExpressionRoutes enabled #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mattia Lavacca <[email protected]>
2 tasks
randmonkey
force-pushed
the
fix/expression_httproute_conformance_tests
branch
from
62336a4
to
1de664f
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4359 +/- ##
=======================================
- Coverage 65.5% 65.5% -0.1%
=======================================
Files 154 154
Lines 17735 17740 +5
=======================================
- Hits 11630 11629 -1
- Misses 5375 5379 +4
- Partials 730 732 +2
☔ View full report in Codecov by Sentry. |
czeslavo
reviewed
Jul 17, 2023
mlavacca
previously approved these changes
Jul 17, 2023
|
E2E (targeted) tests with KIND-based clusters were started at https:/Kong/kubernetes-ingress-controller/actions/runs/5574265092 |
mlavacca
reviewed
Jul 17, 2023
czeslavo
approved these changes
Jul 18, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Set
StripPathtofalseto Kong routes translated fromHTTPRoutewhenExpressionRoutesenabled, to pass the gateway API conformance tests. The PR will also switch conformance tests to run withExpressionRoutesenabled.Which issue this PR fixes:
fixes #4352 and #4164
Special notes for your reviewer:
Also enables conformance to run for both
traditionalandexpressionrouters. But the test titleslooks weird. Any suggestions to display a clearer title on the page?
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR