-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Consumer Groups can be configured in Consumer #4419
Conversation
f745b8d
to
3eeea9e
Compare
3eeea9e
to
6b240b3
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4419 +/- ##
=======================================
- Coverage 67.5% 61.7% -5.8%
=======================================
Files 159 159
Lines 18772 18762 -10
=======================================
- Hits 12681 11588 -1093
- Misses 5327 6502 +1175
+ Partials 764 672 -92
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine on our end. Some copyediting comments.
We may want to dispense with the integration test (especially since it's broken for reasons beyond our control) and only do unit or golden tests for the consumer+group assignment. Ultimately (once plugin assignment is complete) we should end up with a single test that confirms proper mapping by assigning a plugin to the consumer group and confirming that it runs.
Querying the admin API to confirm the objects is atypical.(I thought it odd there was a special workspaced client if case, and then realized that no other integration test has this because this is the only one that checks the admin API. KIC integration tests generally observe the effects of their configuration instead of the config itself, since the effect implies the presence of the configuration.
In terms of testing @rainest I consider this state as intermediate as I've written in PR that introduces this test #4387
So it's a pretty low cost to have it like that for now and later when the full feature will be implemented adjust it. It allowed me to discover problems during development like the broken Kong Gateway. I've introduced a golden test too. |
6b240b3
to
631da10
Compare
eeb8ad6
to
86ab16b
Compare
86ab16b
to
75d72d4
Compare
What this PR does / why we need it:
Introduce the optional field
ConsumerGroups
toKongConsumer
CRD that allows configuring Consumer Groups for Consumer. Add implementation and enhance integration test to cover it.Which issue this PR fixes:
part of #3728
Special notes for your reviewer:
Integration test
TestConsumerGroup
is executed for two set-ups:blocked
) 🔴 so test is skipped for such configuration for nowThe golden test has been introduced for consumer groups with consumers.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR