feat: propagate translation failures for KongPlugin and KongClusterPlugin #4428
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Instead of just logging an error in case of an invalid
KongPlugin
orKongClusterPlugin
's configuration, bubble up the translation failure so that theProgrammed
condition is populated withFalse
and reasonInvalid
and an event is emitted.Also drops unnecessary validation of
plugin.PluginName
which is handled on the Kubernetes API level thanks to the CRD validation (KongPlugin, KongClusterPlugin).Which issue this PR fixes:
Noticed when working on #3344.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR