Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove knative support #4748

Merged
merged 2 commits into from
Sep 28, 2023
Merged

chore: remove knative support #4748

merged 2 commits into from
Sep 28, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Sep 28, 2023

What this PR does / why we need it:

Removes knative support.

Which issue this PR fixes:

Related #2813

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9c19f60) 67.8% compared to head (00160b8) 67.6%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4748     +/-   ##
=======================================
- Coverage   67.8%   67.6%   -0.2%     
=======================================
  Files        165     163      -2     
  Lines      19066   18667    -399     
=======================================
- Hits       12927   12621    -306     
+ Misses      5380    5311     -69     
+ Partials     759     735     -24     
Files Coverage Δ
internal/annotations/annotations.go 98.7% <ø> (ø)
internal/controllers/utils/utils.go 95.6% <ø> (-2.7%) ⬇️
internal/dataplane/parser/parser.go 81.7% <ø> (-3.1%) ⬇️
internal/dataplane/parser/translate_utils.go 94.1% <ø> (+4.8%) ⬆️
internal/manager/config.go 95.0% <ø> (-0.1%) ⬇️
internal/manager/controllerdef.go 99.4% <ø> (-0.1%) ⬇️
internal/manager/featuregates/feature_gates.go 100.0% <ø> (ø)
internal/manager/scheme/scheme.go 22.2% <ø> (-0.4%) ⬇️
internal/store/fake_store.go 38.6% <ø> (-0.6%) ⬇️
internal/store/store.go 62.5% <ø> (+0.3%) ⬆️
... and 1 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek marked this pull request as ready for review September 28, 2023 10:17
@pmalek pmalek requested a review from a team as a code owner September 28, 2023 10:17
programmer04
programmer04 previously approved these changes Sep 28, 2023
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹
Also, Helm chart has to be adjusted to not install Knative-related stuff for KIC >=3.0

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@programmer04 programmer04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺 removing code is the best thing

@pmalek pmalek merged commit edfd7e2 into main Sep 28, 2023
31 checks passed
@pmalek pmalek deleted the remove-knative-support branch September 28, 2023 15:20
@pmalek pmalek mentioned this pull request Sep 28, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants