Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restrict supported versions of Kong to >= 3.4.1 #4766

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

programmer04
Copy link
Member

@programmer04 programmer04 commented Oct 2, 2023

What this PR does / why we need it:

KIC refuses to start when Kong Gateway is not in the version >= 3.4.1 also it won't discover such Gateway. Tests and CI have been adjusted. Code cleanups will be handled in separate PR. Testing for older versions that don't support Kong Gateway discovery is redundant now, also support for them will be removed entirely in

Which issue this PR fixes:

Part of #4764, next PR will get rid of redundant version checks in the whole codebase for the above

// RegexHeaderVersionCutoff is the Kong version prior to the addition of support for regular expression for matching headers.
RegexHeaderVersionCutoff = semver.Version{Major: 2, Minor: 8}
// ExplicitRegexPathVersionCutoff is the lowest Kong version requiring the explicit "~" prefixes in regular expression paths.
ExplicitRegexPathVersionCutoff = semver.Version{Major: 3, Minor: 0}
// PluginOrderingVersionCutoff is the Kong version prior to the addition of plugin ordering.
PluginOrderingVersionCutoff = semver.Version{Major: 3}
// ConsumerGroupsVersionCutoff is the Kong version prior to the addition of Consumer Groups as first class citizens.
ConsumerGroupsVersionCutoff = semver.Version{Major: 3, Minor: 4}
// MTLSCredentialVersionCutoff is the minimum Kong version that support mTLS credentials. This is a patch version
// because the original version of the mTLS credential was not compatible with KIC.
MTLSCredentialVersionCutoff = semver.Version{Major: 2, Minor: 3, Patch: 2}
// FlattenedErrorCutoff is the lowest Kong version with support for flattened errors.
FlattenedErrorCutoff = semver.Version{Major: 3, Minor: 2}
// TLSPassthroughCutoff is the lowest Kong version with support for TLS passthrough.
TLSPassthroughCutoff = semver.Version{Major: 2, Minor: 7}
// ExpressionRouterL4Cutoff is the lowest Kong version with support of L4 proxy in expression router.
ExpressionRouterL4Cutoff = semver.Version{Major: 3, Minor: 4}

and adjusting the Helm chart.

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@programmer04 programmer04 changed the title chore: restrict versions of Kong to >= 3.4.1 chore: restrict supported versions of Kong to >= 3.4.1 Oct 2, 2023
@programmer04 programmer04 added this to the KIC v3.0.0 milestone Oct 2, 2023
@programmer04 programmer04 self-assigned this Oct 2, 2023
@programmer04 programmer04 marked this pull request as ready for review October 2, 2023 16:16
@programmer04 programmer04 requested a review from a team as a code owner October 2, 2023 16:16
@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Oct 2, 2023
@programmer04 programmer04 enabled auto-merge (squash) October 2, 2023 16:16
@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (a7d258a) 77.7% compared to head (7783220) 77.7%.

❗ Current head 7783220 differs from pull request most recent head a0fe995. Consider uploading reports for the commit a0fe995 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4766   +/-   ##
=====================================
  Coverage   77.7%   77.7%           
=====================================
  Files        163     163           
  Lines      18523   18540   +17     
=====================================
+ Hits       14409   14424   +15     
+ Misses      3309    3300    -9     
- Partials     805     816   +11     
Files Coverage Δ
internal/adminapi/kong.go 61.9% <73.9%> (+1.6%) ⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

internal/manager/run.go Outdated Show resolved Hide resolved
@programmer04 programmer04 marked this pull request as draft October 4, 2023 08:48
auto-merge was automatically disabled October 4, 2023 08:48

Pull request was converted to draft

@pull-request-size pull-request-size bot added size/L and removed size/S labels Oct 4, 2023
@Kong Kong deleted a comment from team-k8s-bot Oct 9, 2023
@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Oct 9, 2023
@programmer04 programmer04 marked this pull request as ready for review October 9, 2023 08:35
@programmer04 programmer04 enabled auto-merge (squash) October 9, 2023 08:36
@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 9, 2023
@Kong Kong deleted a comment from team-k8s-bot Oct 9, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https:/Kong/kubernetes-ingress-controller/actions/runs/6455720222

@programmer04 programmer04 added the ci/run-e2e Trigger e2e test run from PR label Oct 10, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https:/Kong/kubernetes-ingress-controller/actions/runs/6468643418

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants