-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: restrict supported versions of Kong to >= 3.4.1 #4766
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4766 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 163 163
Lines 18523 18540 +17
=====================================
+ Hits 14409 14424 +15
+ Misses 3309 3300 -9
- Partials 805 816 +11
☔ View full report in Codecov by Sentry. |
Pull request was converted to draft
3085819
to
60e070d
Compare
E2E (targeted) tests with KIND-based clusters were started at https:/Kong/kubernetes-ingress-controller/actions/runs/6455720222 |
E2E (targeted) tests with KIND-based clusters were started at https:/Kong/kubernetes-ingress-controller/actions/runs/6468643418 |
What this PR does / why we need it:
KIC refuses to start when Kong Gateway is not in the version
>= 3.4.1
also it won't discover such Gateway. Tests and CI have been adjusted. Code cleanups will be handled in separate PR. Testing for older versions that don't support Kong Gateway discovery is redundant now, also support for them will be removed entirely inWhich issue this PR fixes:
Part of #4764, next PR will get rid of redundant version checks in the whole codebase for the above
kubernetes-ingress-controller/internal/versions/versions.go
Lines 11 to 34 in fc81ee4
and adjusting the Helm chart.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR