Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: HTTPRoute extensionRef filter converted onto plugin #4838

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Oct 12, 2023

What this PR does / why we need it:

Which issue this PR fixes:

Fixes #4812

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (46929c1) 77.7% compared to head (b19b294) 77.5%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #4838     +/-   ##
=======================================
- Coverage   77.7%   77.5%   -0.2%     
=======================================
  Files        165     166      +1     
  Lines      18480   18633    +153     
=======================================
+ Hits       14359   14458     +99     
- Misses      3296    3335     +39     
- Partials     825     840     +15     
Files Coverage Δ
...rnal/dataplane/parser/translators/httproute_atc.go 90.8% <25.0%> (-2.2%) ⬇️
internal/dataplane/parser/translate_httproute.go 75.0% <29.4%> (-2.7%) ⬇️
internal/dataplane/parser/translators/httproute.go 86.9% <54.7%> (-5.0%) ⬇️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlavacca mlavacca marked this pull request as ready for review October 23, 2023 12:22
@mlavacca mlavacca requested a review from a team as a code owner October 23, 2023 12:22
Signed-off-by: Mattia Lavacca <[email protected]>
@programmer04
Copy link
Member

Linter complains @mlavacca

programmer04
programmer04 previously approved these changes Oct 24, 2023
CHANGELOG.md Show resolved Hide resolved
internal/dataplane/parser/translators/httproute.go Outdated Show resolved Hide resolved
internal/dataplane/parser/translators/httproute.go Outdated Show resolved Hide resolved
pmalek
pmalek previously approved these changes Oct 24, 2023
@pmalek pmalek added the area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API label Oct 24, 2023
@pmalek pmalek added this to the KIC v3.0.0 milestone Oct 24, 2023
@mlavacca mlavacca merged commit 419cd07 into main Oct 24, 2023
35 checks passed
@mlavacca mlavacca deleted the mlavacca/httproute-plugins branch October 24, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert HTTPRoute custom filters into Kong Route plugins
3 participants