feat: add KongUpstreamPolicy CRD validation rules #4955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
feat/kongupstreampolicy-validations
branch
from
ff23b3f
to
a342fd6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4955 +/- ##
=====================================
Coverage 77.8% 77.8%
=====================================
Files 166 166
Lines 18591 18591
=====================================
+ Hits 14470 14476 +6
+ Misses 3295 3289 -6
Partials 826 826
☔ View full report in Codecov by Sentry. |
rainest
approved these changes
Oct 24, 2023
pmalek
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
KongUpstreamPolicyCRD validations (both CEL rules as well as regular min/max for HTTP status codes). It will allow us to make assumptions on data validity in the controller.Which issue this PR fixes:
Closes #4951.