Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): The log format starts with a capital letter in internal/dataplane #5065

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

pangruoran
Copy link
Contributor

@pangruoran pangruoran commented Nov 2, 2023

What this PR does / why we need it:

Which issue this PR fixes:

fixes: #3708
Special notes for your reviewer:

This PR more about internal/dataplane

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@pangruoran pangruoran marked this pull request as ready for review November 2, 2023 17:08
@pangruoran pangruoran requested a review from a team as a code owner November 2, 2023 17:08
CHANGELOG.md Show resolved Hide resolved
@pangruoran
Copy link
Contributor Author

This will be the last PR for this part of the modification. (it will close #3708)
I hope it can be merged before the release of version 3.0.
Thanks

pmalek
pmalek previously approved these changes Nov 2, 2023
@pangruoran
Copy link
Contributor Author

Sorry, I missed a modification. It has been updated.

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (6fb8469) 73.3% compared to head (5687410) 75.6%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5065     +/-   ##
=======================================
+ Coverage   73.3%   75.6%   +2.2%     
=======================================
  Files        167     167             
  Lines      18909   18909             
=======================================
+ Hits       13867   14297    +430     
+ Misses      4218    3788    -430     
  Partials     824     824             
Files Coverage Δ
internal/dataplane/kongstate/route.go 97.5% <100.0%> (ø)
internal/dataplane/parser/backendref.go 100.0% <100.0%> (ø)
internal/dataplane/parser/ingressrules.go 95.1% <100.0%> (ø)
internal/dataplane/parser/translate_udproute.go 67.7% <100.0%> (ø)
internal/dataplane/parser/parser.go 91.1% <91.6%> (-1.2%) ⬇️
internal/dataplane/parser/translate_httproute.go 70.3% <0.0%> (ø)
internal/dataplane/parser/translate_tlsroute.go 56.9% <0.0%> (ø)
internal/dataplane/sendconfig/kong.go 52.3% <50.0%> (ø)
internal/dataplane/sendconfig/sendconfig.go 82.4% <0.0%> (+31.0%) ⬆️
internal/dataplane/synchronizer.go 93.5% <66.6%> (+3.8%) ⬆️
... and 7 more

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pmalek
pmalek previously approved these changes Nov 2, 2023
Copy link
Contributor

@randmonkey randmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubernetes-ingress-controller/test/integration/translation_failures_test.go should be updated to match the modified translation failure reasons.

internal/dataplane/kong_client.go Show resolved Hide resolved
@pangruoran pangruoran merged commit 6e1bbc9 into main Nov 3, 2023
35 checks passed
@pangruoran pangruoran deleted the unified-log-case-part8 branch November 3, 2023 04:29
czeslavo pushed a commit that referenced this pull request Nov 3, 2023
czeslavo added a commit that referenced this pull request Nov 3, 2023
…dataplane (#5065) (#5083)

(cherry picked from commit 6e1bbc9)

Co-authored-by: Ran Z <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent logs capitalization
3 participants