feat: add CRD validation expression for KongPlugin and KongClusterPlugin config and configFrom fields
#5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
force-pushed
the
crd-validation-expressions-plugins-can-only-set-config-or-configFrom
branch
from
0030a65
to
51f13ca
Compare
pmalek
changed the title
KongPlugin and KongClusterPlugin config and configFrom fields
…gin config and configFrom fields
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5119 +/- ##
=======================================
+ Coverage 75.7% 77.8% +2.1%
=======================================
Files 167 167
Lines 18911 18908 -3
=======================================
+ Hits 14320 14718 +398
+ Misses 3770 3359 -411
- Partials 821 831 +10
☔ View full report in Codecov by Sentry. |
pmalek
force-pushed
the
crd-validation-expressions-plugins-can-only-set-config-or-configFrom
branch
from
51f13ca
to
e3fcc28
Compare
czeslavo
reviewed
Nov 8, 2023
Co-authored-by: Grzegorz Burzyński <[email protected]>
…set-config-or-configFrom
czeslavo
previously approved these changes
Nov 8, 2023
…set-config-or-configFrom
pangruoran
approved these changes
Nov 9, 2023
czeslavo
approved these changes
Nov 9, 2023
pmalek
deleted the
crd-validation-expressions-plugins-can-only-set-config-or-configFrom
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds CRD validation expression to
KongPluginandKongClusterPluginto enforce only one ofconfigandconfigFromfields to be set using the CRD validation expressions.Which issue this PR fixes:
Related to #5062 (just a small part of it).
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR