fix: set tags on GRPCRoute routes #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
programmer04
requested changes
Dec 1, 2023
rainest
force-pushed
the
fix/grpcroute-tags
branch
2 times, most recently
from
3f23c32
to
47dc812
Compare
programmer04
previously approved these changes
Dec 1, 2023
rainest
force-pushed
the
fix/grpcroute-tags
branch
from
47dc812
to
12a8350
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5267 +/- ##
=======================================
+ Coverage 75.4% 75.5% +0.1%
=======================================
Files 170 170
Lines 19350 19352 +2
=======================================
+ Hits 14593 14614 +21
+ Misses 3930 3916 -14
+ Partials 827 822 -5 ☔ View full report in Codecov by Sentry. |
programmer04
approved these changes
Dec 1, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds source entity tags to GRPCRoute in the traditional translator.
Which issue this PR fixes:
We forgot to put source entity tags on GRPCRoute and were unable to attach admin API errors to them.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR