Backport --emit-kubernetes-events to release/2.12.x
#5305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anslation and config applying (#5296) * add --emit-translation-events to toggle creating of events in translation and config applying * update changelog * Update internal/manager/run.go Co-authored-by: Jintao Zhang <[email protected]> * Capitalize logs Co-authored-by: Jakub Warczarek <[email protected]> --------- Co-authored-by: Jintao Zhang <[email protected]> Co-authored-by: Jakub Warczarek <[email protected]> (cherry picked from commit 8b3d551)
tao12345666333
commented
Dec 7, 2023
czeslavo
previously approved these changes
Dec 7, 2023
|
Please run |
Signed-off-by: Jintao Zhang <[email protected]>
|
Thanks! 👍 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/2.12.x #5305 +/- ##
================================================
- Coverage 68.0% 67.9% -0.1%
================================================
Files 165 165
Lines 19344 19352 +8
================================================
- Hits 13159 13157 -2
- Misses 5397 5405 +8
- Partials 788 790 +2 ☔ View full report in Codecov by Sentry. |
czeslavo
previously approved these changes
Dec 7, 2023
2 tasks
Signed-off-by: Jintao Zhang <[email protected]>
randmonkey
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Backport #5296 #5299 to release/2.12.x branch.
Which issue this PR fixes:
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR