-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement controller and translator for KongVault #5384
Conversation
4b7c770
to
8bd7169
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5384 +/- ##
=======================================
- Coverage 69.5% 69.4% -0.2%
=======================================
Files 174 174
Lines 21934 22192 +258
=======================================
+ Hits 15258 15402 +144
- Misses 5780 5880 +100
- Partials 896 910 +14 ☔ View full report in Codecov by Sentry. |
af699cd
to
51b2130
Compare
b2f1092
to
b5effab
Compare
b5effab
to
2111597
Compare
2111597
to
94c4c8e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity, since this is called out as incomplete, what are the specific remaining tasks? We should always try to mention those since reviewers won't inherently have that context, and can't accurately gauge whether a partial implementation will be compatible with the assumed future next steps.
Updated the comments on the PR and listed the follow up things after this PR. |
What this PR does / why we need it:
Implement the controller and the translator of
KongVault
to generate and configuration of custom vaults.Which issue this PR fixes:
Major part of #5333.
Special notes for your reviewer:
Although the controller is not fully completed yet, to avoid the PR being too large to review, please review it and do not require a significant change on this PR.
Remaining parts:
prefix
field inKongVault
resources #5395 Validate the uniqueness ofprefix
prefix
field inKongVault
resources #5395 )PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR