-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
define KongLicense CRD #5487
define KongLicense CRD #5487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to name the status of the KongLicense reconciled in each controller, parents or controllers?
I think that controllers
is more precise, but I'm OK with parents
as well.
Should we import types from gateway API, or define our own types?
I think we should not rely on Gateway API in this case as it's not a CRD that's somehow interconnected with this "world".
Do we need a field to store the type of the controller?
I think we don't as long as we keep the ControllerName
unique between controllers/controllers' instances (as I wrote in the comment).
Should we have Phase and what phases do we have? Pending -> Accepted -> Configured?
I'd skip Phase
for now and just use []metav1.Conditions
which is more common and easy to extend.
Should we add conditions and transition time between each step?
Ditto.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5487 +/- ##
=====================================
Coverage 69.7% 69.8%
=====================================
Files 176 176
Lines 22857 22873 +16
=====================================
+ Hits 15949 15982 +33
+ Misses 5961 5948 -13
+ Partials 947 943 -4 ☔ View full report in Codecov by Sentry. |
13f7ec0
to
d18d4ba
Compare
b92b8cd
to
ca1bc85
Compare
ca1bc85
to
6b4b884
Compare
acb443a
to
2f465a1
Compare
Signed-off-by: Jintao Zhang <[email protected]>
a8c9a7e
fixed the lint error. |
What this PR does / why we need it:
define
KongLicense
CRD for storing a Kong license and applying it to Kong gateway.Which issue this PR fixes:
First step of #5437
Special notes for your reviewer:
Not finished yet, but the structure of the CRD is basically determined. Major uncertain parts:KongLicense
reconciled in each controller,parents
orcontrollers
? (controllers
)controllerName
to identify controllers)PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR