feat: enable Konnect config dumps sanitization by default #5573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
sanitize-konnect-default-on
branch
2 times, most recently
from
9acf666
to
0d0fbd2
Compare
programmer04
previously approved these changes
Feb 6, 2024
pmalek
reviewed
Feb 6, 2024
czeslavo
force-pushed
the
sanitize-konnect-default-on
branch
from
0d0fbd2
to
4837b64
Compare
czeslavo
force-pushed
the
sanitize-konnect-default-on
branch
from
4837b64
to
b56f976
Compare
pmalek
approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5573 +/- ##
=====================================
Coverage 71.2% 71.3%
=====================================
Files 177 177
Lines 18301 18301
=====================================
+ Hits 13041 13055 +14
+ Misses 4310 4300 -10
+ Partials 950 946 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
@mheap suggested we might want to make this feature gate enabled by default.
Which issue this PR fixes:
Part of #5467.
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR