-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: managed gateways config pushed when accepted #5662
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5662 +/- ##
=======================================
- Coverage 71.7% 71.6% -0.1%
=======================================
Files 176 176
Lines 18164 18163 -1
=======================================
- Hits 13038 13022 -16
- Misses 4177 4183 +6
- Partials 949 958 +9 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Mattia Lavacca <[email protected]>
993baff
to
cc50b1a
Compare
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.1.x release/3.1.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.1.x
# Create a new branch
git switch --create backport-5662-to-release/3.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0d757a0f2895665655c034a80c7d9e16c2b8855c
# Push it to GitHub
git push --set-upstream origin backport-5662-to-release/3.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.1.x Then, create a pull request where the |
Signed-off-by: Mattia Lavacca <[email protected]>
* feat: managed gateways config pushed when accepted (#5662) Signed-off-by: Mattia Lavacca <[email protected]> * fix(controllers) skip routes bound to excluded GWs (#5642) In single-Gateway mode, properly skip route parent references for other Gateways when determining whether to include a route. * chore: generate validating webhook config using controller-gen (#5659) * tests: port KongVault validation webhook tests to envtests (#5605) Co-authored-by: Patryk Małek <[email protected]> --------- Signed-off-by: Mattia Lavacca <[email protected]> Co-authored-by: Travis Raines <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]> Co-authored-by: Patryk Małek <[email protected]>
* feat: managed gateways config pushed when accepted (#5662) Signed-off-by: Mattia Lavacca <[email protected]> * fix(controllers) skip routes bound to excluded GWs (#5642) In single-Gateway mode, properly skip route parent references for other Gateways when determining whether to include a route. * chore: generate validating webhook config using controller-gen (#5659) * tests: port KongVault validation webhook tests to envtests (#5605) Co-authored-by: Patryk Małek <[email protected]> --------- Signed-off-by: Mattia Lavacca <[email protected]> Co-authored-by: Travis Raines <[email protected]> Co-authored-by: Grzegorz Burzyński <[email protected]> Co-authored-by: Patryk Małek <[email protected]>
What this PR does / why we need it:
All the gateways (managed and unmanaged) are pushed to the dataplane. The condition for it is to have them accepted.
Which issue this PR fixes:
Fixes: #5600
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR