fix: create multiple SNIs when same certificate is reused #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen in #75, if multiple Host reference the same certificate, only one host is added as SNI in Kong. This was a bug due to early exit when a GET request for a certificate succeded. There were also edge-cases around change certificate for a Host or updating SNI name. This commit covers those.
Codecov Report
@@ Coverage Diff @@
## master #76 +/- ##
=========================================
- Coverage 32.45% 32.3% -0.15%
=========================================
Files 33 33
Lines 2835 2848 +13
=========================================
Hits 920 920
- Misses 1802 1815 +13
Partials 113 113
Continue to review full report at Codecov.
|
p0pr0ck5
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #75, if multiple Host reference the same certificate, only
one host is added as SNI in Kong. This was a bug due to early exit when
a GET request for a certificate succeded.
There were also edge-cases around change certificate for a Host or
updating SNI name. This commit covers those.
Fixes #75