Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose end line are not covered in coverage #601

Closed
ds-griddynamics opened this issue Apr 25, 2024 · 2 comments · Fixed by #640
Closed

Compose end line are not covered in coverage #601

ds-griddynamics opened this issue Apr 25, 2024 · 2 comments · Fixed by #640
Assignees
@shanshin
Labels
Bug Bug issue type S: ready for release Status: merged in the main branch

Comments

@ds-griddynamics
Copy link

Describe the bug
When generating coverage compose last lines are not covered check screenshot, I have tried will all next version 0.7.x and 0.8.x none of them are working.

Errors
If present, stacktraces or files from build/kover/errors directory

Expected behavior
A clear and concise description of what you expected to happen.

Reproducer

Reports
If applicable, report files or screenshots.

Screenshot 2024-04-25 at 9 05 51 PM

Environment

  • Kover Gradle Plugin version: 0.6.1
  • Gradle version: 8.3.0
  • Kotlin project type: Kotlin/Android
  • Coverage Toolset : Kover
  • Other context important for this bug: [e.g. OS version]
@ds-griddynamics ds-griddynamics added Bug Bug issue type S: untriaged Status: issue reported but unprocessed labels Apr 25, 2024
@galex
Copy link

galex commented May 19, 2024 •
edited
Loading

Got here because of the same issue!

Screenshot 2024-05-19 at 22 15 42

Start and end of this function are considered untested branches and instructions apparently.
Probably because of the magic of the Compose Compiler that adds $recomposer and other parameters and code... 🤔

@shanshin shanshin added S: confirmed Status: bug is reproduced or present and removed S: untriaged Status: issue reported but unprocessed labels Jun 10, 2024
shanshin added a commit that referenced this issue Jun 19, 2024
@shanshin
Added compose tests
0c5ddaa 
Fixes #601
@shanshin shanshin mentioned this issue Jun 19, 2024
Merged
shanshin added a commit that referenced this issue Jun 27, 2024
@shanshin
Added compose tests
e5ac80f 
Fixes #601
shanshin added a commit that referenced this issue Jun 27, 2024
@shanshin
Added compose tests
8cee8cb 
Fixes #601

PR #640
@shanshin shanshin reopened this Jun 27, 2024
@shanshin shanshin added S: ready for release Status: merged in the main branch and removed S: confirmed Status: bug is reproduced or present labels Jun 27, 2024
@shanshin
Copy link
Collaborator

Fixed in 0.8.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanshin shanshin

Labels
Bug Bug issue type S: ready for release Status: merged in the main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added compose tests Kotlin/kotlinx-kover
3 participants
@galex @shanshin @ds-griddynamics