Support zstd-stream gateway compression #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jb3
force-pushed
the
jb3/zstd
branch
2 times, most recently
from
1498b81
to
3560892
Compare
jchristgit
reviewed
May 18, 2024
This adds support for zstd-stream compression through configuration of the :gateway_compression configuration option. This will optionally use the :ezstd library to decompress received payloads from Discord allowing for some potential savings on payload size. This also moves the ws_state to be agnostic and references the compression context as `compress_ctx` instead of the previous `zlib_ctx`.
jchristgit
reviewed
May 18, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for zstd-stream compression through configuration of the
:gateway_compressionconfiguration option.This will optionally use the
:ezstdlibrary to decompress received payloads fromDiscord allowing for some potential savings on payload size.
This also moves the ws_state to be agnostic and references the compression
context as
compress_ctxinstead of the previouszlib_ctx.We add an optional dependency for
:ezstd. I have not made this mandatory as itrequires natively built functions and as such I cannot guarantee how
cross-platform it is or in what environments it will build.
zstd-streamcompression is documented upstream by discord/discord-api-docs#6877.