Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Dynamic methods for DbSet #12

Open
Burgyn opened this issue Apr 3, 2019 · 0 comments · May be fixed by #16
Open

Use Dynamic methods for DbSet #12

Burgyn opened this issue Apr 3, 2019 · 0 comments · May be fixed by #16
Assignees
@LukasSefcik
Labels
enhancement New feature or request Pending PR up-for-grabs

Comments

@Burgyn
Copy link
Member

Burgyn commented Apr 3, 2019

KORM use reflection for generating insert/update commands and setting generated ids into entities. (starting method is CommitChangesAddedItemsAsync in DbSet)
We can use DynamicMethods as in DynamicMethodModelFactory. This can improve performance.
@Burgyn Burgyn added enhancement New feature or request up-for-grabs labels Apr 3, 2019
@LukasSefcik LukasSefcik self-assigned this May 20, 2019
@LukasSefcik LukasSefcik linked a pull request May 23, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasSefcik LukasSefcik

Labels
enhancement New feature or request Pending PR up-for-grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP Use dynamic method in DbSet. LukasSefcik/Kros.KORM
2 participants
@Burgyn @LukasSefcik