Implement scheduled notifications #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleKun
approved these changes
Dec 11, 2022
|
Amazing, is the repo auto published to the app store or are releases made manually? |
Manually, the new update is coming in January on PlayStore, along with a lot more features. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should successfully close #21
The Notification toggle has been converted into a button that leads to a dedicated page that contains 3 buttons:
The default time when none is set is 20:00 or 8:00 PM in the local time zone of the user. Schedules are also set to work in the user's local time, and the previous logic for assigning notifications has been replaced by a slightly more efficient approach.
The test button is used to display how notifications would work on the device and the option would be hidden while notifications are disabled.
The page and all the new content have also been localized and tested for the available in-app languages.
Please let me know if you'd like any changes, thanks.