Add outline with inverted color to texts #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daoxve
force-pushed
the
fix/textOutline
branch
3 times, most recently
from
0cb8ea2
to
12cf0f6
Compare
|
Left some comments on the previous PR, since this has the same commits not merging it yet, but otherwise, this particular feature LGTM! |
|
Ahh thanks, my bad 😅 Some of the code here depends on the code from that PR branch, but I can fix this once everything goes well and the other PR is merged! |
|
I might have to redo this PR to not mess up the commit history :D |
Merged the other one! |
daoxve
force-pushed
the
fix/textOutline
branch
from
6a0494a
to
dbbc5b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the PR @waitingwillykitty
I've adapted the code to work with the new FFmpeg implementation.
This PR should fix issue #17 & close PR #28