-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add subtitles feature #39
Conversation
Hey @daoxve , would you mind taking a quick look just to check if I am not doing any mess here :p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would work without any conflicts with my branch 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
What does it mean in a player that supports them? Would be really great to have an option to hardcode the subtitles into the image when making a movie. |
Most players support loading subtitles, tbh I see no clear reason to hardcode when you can enable / disable as wanted, I see a disadvantage where large subtitles (3+ lines) would compromise the view of what's behind. |
I watched the movie from your app in Google Photos (it syncs nicely into it automatically from my phone), but dont see any subtitles. I would like to share the movie with people from Google Photos and for them to see the subtitle descriptions as well, but unfortunately that use case is not supported. |
Curiously it seems Google Photos doesn't support subtitles: https://support.google.com/photos/thread/145742516?hl=en&msgid=145824388 VLC should show them, do they show up in the calendar view as "Edit subtitles"? And you're welcome :) |
I discovered the reason VLC did not show subtitles - because I downloaded the movie file from Google Photos and Google Photos converts the video on upload and appears to remove the subtitle track in the process. |
Yes, Google Drive, I just tested and it works, the only thing is that you need to tap the CC button and select the "unknown" option to show the subtitles. |
Added a new text field to add subtitles that can be seen in a player that supports it.
Fixed some localized strings.