Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subtitles feature #39

Merged
merged 3 commits into from
Dec 22, 2022
Merged

Add subtitles feature #39

merged 3 commits into from
Dec 22, 2022

Conversation

KyleKun
Copy link
Owner

@KyleKun KyleKun commented Dec 21, 2022

Added a new text field to add subtitles that can be seen in a player that supports it.
Fixed some localized strings.

@KyleKun
Copy link
Owner Author

KyleKun commented Dec 21, 2022

Hey @daoxve , would you mind taking a quick look just to check if I am not doing any mess here :p

Copy link
Contributor

@daoxve daoxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would work without any conflicts with my branch 🚀

Copy link
Contributor

@daoxve daoxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@KyleKun KyleKun merged commit 37a72b1 into main Dec 22, 2022
@KyleKun KyleKun deleted the dev branch December 22, 2022 00:22
@KristjanLaane
Copy link

What does it mean in a player that supports them? Would be really great to have an option to hardcode the subtitles into the image when making a movie.

@KyleKun
Copy link
Owner Author

KyleKun commented Jul 10, 2023

What does it mean in a player that supports them? Would be really great to have an option to hardcode the subtitles into the image when making a movie.

Most players support loading subtitles, tbh I see no clear reason to hardcode when you can enable / disable as wanted, I see a disadvantage where large subtitles (3+ lines) would compromise the view of what's behind.

@KristjanLaane
Copy link

I watched the movie from your app in Google Photos (it syncs nicely into it automatically from my phone), but dont see any subtitles. I would like to share the movie with people from Google Photos and for them to see the subtitle descriptions as well, but unfortunately that use case is not supported.
I also tried to see if VLC on my desktop would show the subtitles as a workaround, but it could not detect any subtitle track in the file. Is there any specific player you could highlight that should show the subtitles?
And thank you for an amazing app btw!

@KyleKun
Copy link
Owner Author

KyleKun commented Jul 10, 2023

I watched the movie from your app in Google Photos (it syncs nicely into it automatically from my phone), but dont see any subtitles. I would like to share the movie with people from Google Photos and for them to see the subtitle descriptions as well, but unfortunately that use case is not supported.
I also tried to see if VLC on my desktop would show the subtitles as a workaround, but it could not detect any subtitle track in the file. Is there any specific player you could highlight that should show the subtitles?
And thank you for an amazing app btw!

Curiously it seems Google Photos doesn't support subtitles: https://support.google.com/photos/thread/145742516?hl=en&msgid=145824388

VLC should show them, do they show up in the calendar view as "Edit subtitles"?

And you're welcome :)

@KristjanLaane
Copy link

I discovered the reason VLC did not show subtitles - because I downloaded the movie file from Google Photos and Google Photos converts the video on upload and appears to remove the subtitle track in the process.
When I copied the file directly from the phone to my desktop then the subtitle track was present as it should be.
This process is cumbersome though, it’s hassle to download from phone, send it to people I want to share it with and ask them to download it to the desktop and use VLC. Even if they download it to their phone then Android native video player does not seem to support subtitles either. Do you know of any online service I can upload my video to that shows subtitles automatically and that I could share a link to so at least the people I share it with dont have to do any work to see the subtitles?

@KyleKun
Copy link
Owner Author

KyleKun commented Jul 10, 2023

I discovered the reason VLC did not show subtitles - because I downloaded the movie file from Google Photos and Google Photos converts the video on upload and appears to remove the subtitle track in the process.
When I copied the file directly from the phone to my desktop then the subtitle track was present as it should be.
This process is cumbersome though, it’s hassle to download from phone, send it to people I want to share it with and ask them to download it to the desktop and use VLC. Even if they download it to their phone then Android native video player does not seem to support subtitles either. Do you know of any online service I can upload my video to that shows subtitles automatically and that I could share a link to so at least the people I share it with dont have to do any work to see the subtitles?

Yes, Google Drive, I just tested and it works, the only thing is that you need to tap the CC button and select the "unknown" option to show the subtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants