Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve custom selection page #42

Merged
merged 3 commits into from
Dec 23, 2022
Merged

Improve custom selection page #42

merged 3 commits into from
Dec 23, 2022

Conversation

KyleKun
Copy link
Owner

@KyleKun KyleKun commented Dec 23, 2022 •
edited
Loading

  • Added Select All and Deselect All buttons
  • Added Scrollbar for easier navigation when the list of videos is big
  • Added thumbnails caching, avoiding loading previously shown images
  • Added missing localized strings

FYI @daoxve

@KyleKun KyleKun merged commit 2ce5338 into main Dec 23, 2022
@KyleKun KyleKun deleted the selection-improvs branch December 23, 2022 15:00
daoxve
daoxve reviewed Dec 23, 2022
View reviewed changes
Copy link
Contributor

@daoxve daoxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daoxve daoxve daoxve left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KyleKun @daoxve