Calendar editor + several improvements #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Calendar view in home page (UI is not final, needs some serious polish). It leads to a subtitle editor page if a video was recorded for the selected day, otherwise it shows a button to a video from gallery (to be implemented).
Subtitle stream is now added by default (empty text) to all recordings since concat demuxer does not work properly if it is missing in a video. This is also checked when a movie is created, to avoid letting older recordings without a subtitle stream.
UI Tweaks in settings, create movie page and select videos page. Main change is removing scrollbar from select videos since fast scrolling with 500+ items was crashing the app because lots of Futures would start to obtain the thumbnails and not stop even after page popped. Added an action button to jump scroll to bottom or top instead.
Fixed URL launcher and subtitles feature for some edge cases.
Update translations and .MD files.
FYI @daoxve, please let me know if this conflits with what you're doing and I'll adapt what's needed. Thanks!