Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for profiles #50

Merged
merged 12 commits into from
Dec 31, 2022
Merged

Add support for profiles #50

merged 12 commits into from
Dec 31, 2022

Conversation

daoxve
Copy link
Contributor

@daoxve daoxve commented Dec 30, 2022

Hi, season's greetings! 🎄

This PR adds support for user-defined profiles and should resolve issue #18

Creating a new profile will automatically create a subdirectory under a "Profiles" folder in the directory where the app stores videos with the specified profile name.

Recorded videos would also be automatically added to that sub-directory if that particular profile was selected, and the subdirectory would be deleted along with videos for that profile if the user chooses to remove that profile. There is a confirmation dialog to ensure this isn't done by accident 😁

This is also backward compatible, as it would use the normal directory with a "default" profile configuration for all existing and new users unless they set up a new profile manually :)

Please let me know if you'd like any changes,
Thanks!

Copy link
Owner

@KyleKun KyleKun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Will make sure to integrate with calendar, videos count card and movie creation tomorrow.

@KyleKun KyleKun merged commit af60497 into KyleKun:main Dec 31, 2022
@KyleKun KyleKun mentioned this pull request Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants