Get by ID and Get All endpoints #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notatiyyah
requested review from
MirelaGeorgiou,
LBHMKeyworth,
rashmishetty1011 and
LBHSPreston
as code owners
humulla
requested changes
Jun 22, 2021
TechRadarApi.Tests/V1/UseCase/GetAllTechnologiesUseCaseTests.cs
Outdated
Show resolved
Hide resolved
humulla
reviewed
Jun 24, 2021
| [Test] | ||
| [Ignore("Getting a bug - can't stub the DB response")] | ||
|
|
||
| [Fact(Skip = "Cannot mock DynamoDb context")] |
There was a problem hiding this comment.
Why is this test skipped? what is the issue you are facing
There was a problem hiding this comment.
mockDynamoDb.Setup(x => x.ScanAsync<TechnologyDbEntity>(conditions, default).GetRemainingAsync(default))
.ThrowsAsync(exception);
This line ^ doesn't work with the scan async method as it's a 'non-virtual method'. Here's a link for more info. Should I just remove the test?
humulla
reviewed
Jun 24, 2021
humulla
reviewed
Jun 25, 2021
| // Act | ||
| var response = await Client.GetAsync(uri).ConfigureAwait(false); | ||
| // Assert | ||
| response.StatusCode.Should().Be(HttpStatusCode.NoContent); |
There was a problem hiding this comment.
This should change to return an 200 response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this PR
Create the 'Get All Technologies' endpoint and 'Get Technology by ID' endpoint
Checklist