Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

temporal_reduction reduce all arrays by default #756

Open
burlen opened this issue Jun 1, 2023 · 2 comments
Open

temporal_reduction reduce all arrays by default #756

burlen opened this issue Jun 1, 2023 · 2 comments
Labels
2_medium_priority an issue that should be fixed, but is not critical to the next release feature temporal reductions

Comments

@burlen
Copy link
Collaborator

burlen commented Jun 1, 2023

For the sake of usability it's desirable to defaulting to reducing all arrays (see #753). This should be implemented in the applicaiton in response to a user not passing a list of point arrays on the command line. In that case run the metadata phase of the pipeline and add the detected arrays to both the CF writer and tempral_reduction pipeline stages. Note: the temporal_reduction may need some refactoring to handle 2D and 3D data simultaneously.

@burlen burlen added feature 2_medium_priority an issue that should be fixed, but is not critical to the next release temporal reductions labels Jun 1, 2023
@taobrienlbl
Copy link
Collaborator

a quick follow-up: I think that the temporal reduction does already correctly handle 2D and 3D data simultaneously. I've been using it to composite a bunch of ERA5 fields, including both 2D and 3D fields, and it is generating sensible results.

@burlen
Copy link
Collaborator Author

burlen commented Jun 1, 2023

Looking at the cpp app I confirm that is the indeed the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2_medium_priority an issue that should be fixed, but is not critical to the next release feature temporal reductions
Projects
None yet
Development

No branches or pull requests

2 participants