Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Values may overflow in SUNHashMap on Windows #249

Closed
balos1 opened this issue Jan 7, 2023 · 1 comment
Closed

Values may overflow in SUNHashMap on Windows #249

balos1 opened this issue Jan 7, 2023 · 1 comment
Assignees
@balos1
Labels
archos-windows bug

Comments

@balos1
Copy link
Member

balos1 commented Jan 7, 2023

See warnings in https:/LLNL/sundials/actions/runs/3861321674/jobs/6582228224.

D:/a/sundials/sundials/src/sundials/sundials_hashmap.h:26:48: warning: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '14695981039346656037' to '2216829733' [-Woverflow]
   26 | static const unsigned long HASH_PRIME        = 14695981039346656037U;b
@balos1 balos1 self-assigned this Jan 7, 2023
@balos1
Copy link
Member Author

balos1 commented Apr 25, 2023

We need to use unsigned long long on windows.

@balos1 balos1 mentioned this issue Feb 6, 2024
Closed
@balos1 balos1 mentioned this issue Feb 13, 2024
Merged
gardner48 added a commit that referenced this issue Feb 14, 2024
@balos1 @gardner48
Bugfix: hashmap int overflow (#421)
f4f8d16 
Fixes #409 and #249.

---------

Co-authored-by: David Gardner <[email protected]>
@balos1 balos1 closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balos1 balos1

Labels
archos-windows bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@balos1