Enable Fortran interface for 32-bit sunindextype #447
Conversation
balos1
requested review from
gardner48,
cswoodward and
drreynolds
as code owners
…an-32index-buildma
|
@gardner48 I think this is ready to merge, if you approve. |
| find_package(KLU CONFIG) | ||
| find_package(SuiteSparse_config CONFIG) |
There was a problem hiding this comment.
@mmuetzel The issue seems to be with using -DKLU_DIR=<suite_sparse_install_path>/lib64/cmake/KLU alone to provide the config file location. Using either -DKLU_ROOT=<suite_sparse_install_path> or -DCMAKE_PREFIX_PATH=<suite_sparse_install_path> works without the above additions.
@balos1 are you also setting -D<dependency>_DIR variables for the other packages? Using -DKLU_DIR alone didn't work for me with the above additions. I had add -D<dependency>_DIR variables for each dependency which also makes the config work without the above additions.
This issue is tangential to the topic of this PR so I suggest these changes get broken out into a separate PR.
|
@gardner48 All checks passing 😄 |
Updates for LLNL/sundials#447 (Fortran 32-bit Interface) --------- Co-authored-by: Daniel R. Reynolds <[email protected]> Co-authored-by: David Gardner <[email protected]>
Revert changes to FindKLU made in #447
Update the the SWIG generation and CMake build system to support Fortran interfaces for 32-bit or 64-bit sunindextype. --------- Co-authored-by: David Gardner <[email protected]> Co-authored-by: Daniel R. Reynolds <[email protected]>
Revert changes to FindKLU made in #447
This change was supposed to be reverted in #447 but it was missed.
This tweaks the SWIG generation, and CMake build system to support the Fortran interfaces for 32-bit or 64-bit sunindextype as suggested in https:/LLNL/sundials-private/issues/60. Most of the files 'changed' are just the moved or new SWIG generated files. Unfortunately this does make the repository larger in terms of files and bytes.