Don't use VST-provided memory when loading chunks (#3805)

include/aeffectx.h

@@ -101,6 +101,7 @@ const int effEditOpen = 14;
 const int effEditClose = 15;
 const int effEditIdle = 19;
 const int effEditTop = 20;
+const int effSetChunk = 24;
 const int effProcessEvents = 25;
 const int effGetEffectName = 45;
 const int effGetVendorString = 47;

plugins/vst_base/RemoteVstPlugin.cpp

@@ -1385,30 +1385,18 @@ void RemoteVstPlugin::loadPresetFile( const std::string & _file )
 
 void RemoteVstPlugin::loadChunkFromFile( const std::string & _file, int _len )
 {
- char * buf = NULL;
-
- void * chunk = NULL;
- // various plugins need this in order to not crash when setting
- // chunk (also we let the plugin allocate "safe" memory this way)
- const int actualLen = pluginDispatch( 23, 0, 0, &chunk );
-
- // allocated buffer big enough?
- if( _len > actualLen )
- {
- // no, then manually allocate a buffer
- buf = new char[_len];
- chunk = buf;
- }
+ char * chunk = new char[_len];
 
  const int fd = open( _file.c_str(), O_RDONLY | O_BINARY );
  if ( ::read( fd, chunk, _len ) != _len )
  {
  fprintf( stderr, "Error loading chunk from file.\n" );
  }
  close( fd );
- pluginDispatch( 24, 0, _len, chunk );
 
- delete[] buf;
+ pluginDispatch( effSetChunk, 0, _len, chunk );
+
+ delete[] chunk;
 }