Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored BB TCOs in 1.2 show as uncoloured in 1.3 #6555

Closed
Monospace-V opened this issue Oct 31, 2022 · 3 comments
Closed

Colored BB TCOs in 1.2 show as uncoloured in 1.3 #6555

Monospace-V opened this issue Oct 31, 2022 · 3 comments

Comments

@Monospace-V
Copy link
Contributor

Monospace-V commented Oct 31, 2022

Bug Summary

A 1.2 project with coloured TCOs, the colour is not shown on 1.3.
(Corresponding forum post here. I'm surprised this hasn't been noticed...)

Steps to reproduce

Create a project in LMMS 1.2 and color the Beat/Bassline TCOs through the right click context menu. Save.
Open this project in 1.3.
Colours are not showing. (They show if reopening the project in 1.2, though.)

Expected behavior

Colours are retained.

Actual behavior

Colours are lost.

Screenshot

image
image

Affected LMMS versions

1.2.* -> 1.3 alpha

PS: In addition to this, it would be useful if LMMS automatically coded the entire track the same colour, if most of the BB TCOs were already that colour, if imported from 1.2. Or if all BB clips made on a specific BB were the same colour as the most recent clip placed on that BB. This makes placing BB TCOs of the same colour easier.
But if this is fixed first.

@PhysSong
Copy link
Member

Confirmed. Prior to #5573, colors was loaded/saved using QColor::rgb. #5573 changed it to use QColor::name() and broke compatibility.

@messmerd
Copy link
Member

messmerd commented Nov 4, 2022

I can try working on this one this weekend.

@PhysSong
Copy link
Member

PhysSong commented Nov 7, 2022

Fixed in #6563.

@PhysSong PhysSong closed this as completed Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants