Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BB_editor crash when using mousewheel to set new note volume on moved note. [Bug] #963

Closed
mikobuntu opened this issue Jul 9, 2014 · 3 comments
Milestone

Comments

@mikobuntu
Copy link
Contributor

tested on branch stable-1.1 and Master

to reproduce

  1. make a 4/4 beat in the BB_Editor on the default kicker instrument using the step sequencer.
  2. Open this pattern in the piano_Roll , magnify (to easily shift note). Now move any note 1 step forward.
  3. Use the mousewheel on the step where you just moved the note from, to raise the volume of this step <<< this is where the segfault happens. heres the BT

http://paste.ubuntu.com/7772155/

@mikobuntu mikobuntu changed the title B+B_editor crash when using mousewheel to set new note volume. #[Bug] BB_editor crash when using mousewheel to set new note volume on moved note. [Bug] Jul 9, 2014
@diizy
Copy link
Contributor

diizy commented Jul 10, 2014

We need to seriously rewrite how BB-patterns work, as the current way is sort of fragile and unreliable...

I can of course try to see if there's some workaround or hack to prevent crashes, but it's possible that this will stay unfixed in 1.1, as we don't have time to do a proper redesign of the code.

@diizy diizy added this to the 1.1.0 milestone Jul 10, 2014
@eagles051387
Copy link

Vesa out of curiosity here. With this crash and others are we using threads
somewhere? The reason could be the code isnt thread safe.

On Thu, Jul 10, 2014 at 1:41 PM, Vesa V [email protected] wrote:

We need to seriously rewrite how BB-patterns work, as the current way is
sort of fragile and unreliable...

I can of course try to see if there's some workaround or hack to prevent
crashes, but it's possible that this will stay unfixed in 1.1, as we don't
have time to do a proper redesign of the code.


Reply to this email directly or view it on GitHub
#963 (comment).

Jonathan Aquilina

@diizy
Copy link
Contributor

diizy commented Jul 12, 2014

On 07/12/2014 09:11 AM, eagles051387 wrote:

Vesa out of curiosity here. With this crash and others are we using
threads
somewhere? The reason could be the code isnt thread safe.

No, that's not it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants