SFXR: Avoid NaNs by making envelope length minimum 1 sample #1879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a bugfix for a bug that I assume also exists in 1.1, it might be a good idea to rebase this for the stable-1.1 branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The values in the
env_lengtharray are used as divisors, so if they are allowed a range down to 0 the divisions will result in NaN, which propagates throughenv_volall the way tossample, which is the output. This change might remove some minimal amount of "snap" from the sound, but that would in many cases be the sound of some component not liking NaNs.This should at least partly fix #1877. I'm not saying SFXR doesn't include other calculations that might lead to NaN.